Skip to content
This repository has been archived by the owner on Sep 27, 2024. It is now read-only.

Webpack support #8

Closed
leastbad opened this issue Jul 30, 2021 · 7 comments
Closed

Webpack support #8

leastbad opened this issue Jul 30, 2021 · 7 comments
Labels
feature 🚀 New feature or request

Comments

@leastbad
Copy link

Is your proposal related to a problem?

This library looks amazing, but for those of us who won't touch sprockets at a distance, the lack of a build pipeline option is a blocking issue.

Describe the solution you'd like

rails-mini-profiler should offer an npm package version of the assets.

Describe any alternatives you've considered

The alternative is not using the library, sadly.

Additional context

Pretty please?

@hschne hschne added the feature 🚀 New feature or request label Jul 31, 2021
@hschne
Copy link
Owner

hschne commented Jul 31, 2021

Pretty please?

Well, if you ask like that 😛

Webpack support is definitely coming. For the next couple of releases, I'm planning on fixing some bugs, and improving the UI. Improving the UI means more interactivity, thus more Javascript, and there is no way I'm gonna keep fidgeting plain JS and the asset pipeline forever. Sooner or later I'll have to move things into an NPM package.

So yeah. No ETA, but it's on on the horizon. Somewhere 🌅

@leastbad
Copy link
Author

I'm tempted to say that I'd help, but I know from experience that this task is opinionated and fussy.

I hope that you'll comment here if an npm package debuts! It really does look like an amazing and much needed library.

hschne added a commit that referenced this issue Aug 21, 2021
@hschne
Copy link
Owner

hschne commented Aug 21, 2021

@leastbad The latest release should make Rails Mini Profiler usable for people who don't use sprockets/the asset pipeline.

I created a NPM package which contains the assets. I would love if you could give this a try. Let me know how it goes! 🙌

@hschne hschne closed this as completed Aug 21, 2021
@leastbad
Copy link
Author

Sorry for the delay! Thanks for doing this.

It does seem like it's assuming Sprockets is in scope:

         1: from /home/leastbad/.rvm/gems/ruby-2.7.3/gems/rails_mini_profiler-0.3.0/lib/rails_mini_profiler/engine.rb:15:in `block in <class:Engine>'
/home/leastbad/.rvm/gems/ruby-2.7.3/gems/railties-6.1.4/lib/rails/railtie/configuration.rb:97:in `method_missing': undefined method `assets' for #<Rails::Application::Configuration:0x000055fc3206cb68> (NoMethodError)
Did you mean?  asset_host

@hschne
Copy link
Owner

hschne commented Aug 30, 2021

Welp. Well, thanks for giving this a try 🙌

Not sure how this one slipped through. I guess you tried this with rails new --no-sprockets? 🤔

@leastbad
Copy link
Author

I will keep trying whatever you suggest, and hopefully with faster turnaround. Juggling lots of balls, but I am excited for this tool. Plus: I asked for it, the least I can do is follow through.

I'm one of the many who walked away from Sprockets the moment Webpacker became available, and haven't looked back. There's no trace of it in any of our apps.

@hschne
Copy link
Owner

hschne commented Aug 30, 2021

Alright, thanks a lot! Don't worry about the turnaround times 😉

I'll let you know when there's an update!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature 🚀 New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants