Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Contao 4.9 with missing class tl_settings #55

Closed
wants to merge 2 commits into from
Closed

Support Contao 4.9 with missing class tl_settings #55

wants to merge 2 commits into from

Conversation

rabauss
Copy link

@rabauss rabauss commented Feb 18, 2020

The class tl_settings no longer exists in Contao 4.9, so the callback function should instead extend Contao/Backend!

@fritzmg
Copy link

fritzmg commented Feb 19, 2020

Hm, shouldn't it be either \Contao\Backend or Backend? Aren't all DCA files automatically in the Contao namespace? I am not sure.

@fritzmg
Copy link

fritzmg commented Feb 19, 2020

Also technically, the class should not extend anything at all, as it is not using any features of tl_settings or even \Contao\Backend.

@rabauss
Copy link
Author

rabauss commented Feb 19, 2020

I just used the extends from tl_article without thinking :-)
But you'r right there is no need of extends!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants