Skip to content
This repository has been archived by the owner on Apr 15, 2018. It is now read-only.

Rethink coordination retry handling #59

Merged
merged 1 commit into from
Jan 11, 2016

Conversation

hseeberger
Copy link
Owner

In addition to retry handling configuration has been modularized and redundancies have been removed.

@hseeberger hseeberger force-pushed the 31-coordination-retry-handling branch from cc6d637 to eaf10fa Compare January 11, 2016 12:39
@@ -62,7 +62,8 @@ final class ConsulCoordination(prefix: String, clusterName: String, host: String
}
}

override def lock(ttl: Duration)(implicit ec: ExecutionContext, mat: Materializer): Future[LockResult] = {
override def lock[N](self: N, ttl: Duration)(implicit ec: ExecutionContext, mat: Materializer): Future[LockResult] = {
// TODO Make idempotent wrt retries! Actually a retry should not be fully idempotent, but update to the full TTL.
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juanjovazquez, please take a look at EtcdCoordination and apply the same here, if possible.

hseeberger added a commit that referenced this pull request Jan 11, 2016
@hseeberger hseeberger merged commit 1dd4fb3 into master Jan 11, 2016
@hseeberger hseeberger deleted the 31-coordination-retry-handling branch January 11, 2016 12:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant