Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typography/Design improvements #847

Closed
klieret opened this issue Oct 30, 2020 · 16 comments
Closed

Typography/Design improvements #847

klieret opened this issue Oct 30, 2020 · 16 comments
Assignees

Comments

@klieret
Copy link
Member

klieret commented Oct 30, 2020

For being a text-heavy page (which we undoubtedly are), our base font size of 16px is unusually small. Most web design pages recommend 18px (or even larger) for such low-interaction websites.

Sources

I think this would also look much better on this kind of bleak, media deplete layout that most of our sub-pages have. Medium.com for example has even 21px!

@klieret klieret changed the title Typography improvements Typography/Design improvements Oct 30, 2020
@klieret
Copy link
Member Author

klieret commented Oct 30, 2020

I'd also suggest slightly increased page margin.

And perhaps there's more suggestions to make the design a bit friendlier?

@klieret klieret self-assigned this Nov 30, 2020
@NinaPacifier
Copy link

@klieret I am new to open source contribution. May I work on its issue???

@klieret
Copy link
Member Author

klieret commented Dec 14, 2020

Hi @NinaPacifier sure, I haven't started working on this. Design changes are a bit of a "political" topic though, you need to convince people that the results looks better ;)

@NinaPacifier
Copy link

@klieret I will try my best :)

@vinayakd1729
Copy link

I see the font size of main text is 14px through inspect element. 16px seems good with relative to other headings and other elements. I have build some blogs on GitHub pages earlier and I have experience. May I work on this issue?

@hegner
Copy link
Member

hegner commented Feb 6, 2021

@vinayakd1729 - seems this ticket went a bit dormant. Feel free to prepare a merge request with your ideas. We can take it from there then.

@nimishbongale
Copy link
Contributor

Can I take this up @hegner @klieret?

If I get the issue correctly, we are looking to increase the font size by a few px's?

@klieret
Copy link
Member Author

klieret commented Mar 12, 2021

Nobody has submitted a pull request for this so far, so I'm sure it's fine :) Should be pretty trivial code wise and more a question of good design :)

@nimishbongale
Copy link
Contributor

I'd also suggest slightly increased page margin.
And perhaps there's more suggestions to make the design a bit friendlier?

The overall page margin looks fine to me @klieret, but maybe a little more would work as well! Any other suggestions?

@klieret
Copy link
Member Author

klieret commented Mar 12, 2021

@nimishbongale I'm pretty much an amateur in this area ;) Probably best to just play around with different things to tweak, create a couple of screenshots and see what people like :)

@klieret
Copy link
Member Author

klieret commented Apr 30, 2021

I haven't seen a PR to this date, so I will start one myself.

@klieret
Copy link
Member Author

klieret commented Apr 30, 2021

#964

@klieret
Copy link
Member Author

klieret commented Apr 30, 2021

another idea: #965

@nimishbongale
Copy link
Contributor

Have been having some issues with my health lately, I'm sorry for not following up. I'll be sure to give in my insights though!

@klieret
Copy link
Member Author

klieret commented May 3, 2021

Health goes first! No pressure at all, hope you recover soon!

@klieret
Copy link
Member Author

klieret commented Jun 30, 2021

I think we now completed every change that we had discussed, so I will close this.

@klieret klieret closed this as completed Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants