typescript(vx-pattern): re-write package in TypeScript #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristw
reviewed
Sep 18, 2019
| /** Fill applied to circles. */ | ||
| fill?: string; | ||
| /** className applied to circles. */ | ||
| className?: string; |
There was a problem hiding this comment.
How are the props ordered by?
There was a problem hiding this comment.
there is not enforced ordering, I enabled several new rules in the nimbus upgrade but decided that was too big an undertaking / can't auto-fix.
williaster
force-pushed
the
chris--typescript-vx-pattern
branch
from
cc2919a
to
2d01d26
Compare
kristw
reviewed
Oct 2, 2019
kristw
reviewed
Oct 2, 2019
added 6 commits
October 2, 2019 13:15
…in switch/don't break
williaster
force-pushed
the
chris--typescript-vx-pattern
branch
from
2d01d26
to
bbccc9f
Compare
williaster
commented
Oct 4, 2019
|
|
||
| describe('<PatternWaves />', () => { | ||
| beforeEach(() => { | ||
| global.console.error = jest.fn(); |
There was a problem hiding this comment.
highlighting that nimbus mocks out console.error to throw, so we don't have to do this ourselves anymore.
hshoff
approved these changes
Oct 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Enhancements
This PR builds off of #488 which added TypeScript build support, and converts the
@vx/patternpackage toTypeScript.Closes #502.
Testing
/patterns💥 Breaking Changes
PatternOrientationis no longer thedefaultexport of@vx/patterns/lib/constantsand is instead a named export.PatternOrientationis used as the export name if importing from the index:import { PatternOrientation } from '@vx/pattern'@hshoff @schillerk @milesj @techniq @kristw