typescript(vx-heatmap): re-write package in TypeScript #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rudeg
reviewed
Sep 26, 2019
| | 'y' | ||
| | 'fill' | ||
| | 'fillOpacity' | ||
| >) { |
There was a problem hiding this comment.
nit: might be good to move component props type to the separate variable, something like ComponentProps or OwnProps for the better readability
2 tasks
added 8 commits
October 2, 2019 13:20
williaster
force-pushed
the
chris--typescript-vx-heatmap
branch
from
7cb62f0
to
75e1f7e
Compare
hshoff
requested changes
Oct 9, 2019
hshoff
approved these changes
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Enhancements
This PR builds off #488 which introduces Typescript build config, and re-writes the
@vx/heatmappackage in TypeScript.Closes #519.
💥 Breaking Changes
React.Fragments, which requires bumping thepeerDepforreactto^16.3.0-0Tests
/heatmapsdemo.d.tsfiles@hshoff @schillerk @milesj @kristw @Rudeg