typescript(vx-annotation): re-write package in TypeScript #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hshoff
approved these changes
Oct 8, 2019
williaster
force-pushed
the
chris--typescript-vx-annotation
branch
from
d1a590f
to
524e2bf
Compare
kristw
approved these changes
Oct 22, 2019
williaster
force-pushed
the
chris--typescript-vx-annotation
branch
from
524e2bf
to
74807da
Compare
hshoff
approved these changes
Oct 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Enhancements
This PR builds off #488 which introduces Typescript build config, and re-writes the
@vx/annotationpackage in TypeScript.This depends on types for
@vx/group(parent branch),@vx/shape(#507)@vx/point(#490 ). Closes #534.🐛 Bug Fix
xScaleandySclaeprops passed toLinePath, which are not valid props for that component.Tests
.d.tsfiles@vx/shape(typescript(vx-shape): Re-write package in TypeScript #507)@vx/point(typescript(vx-point): Re-write package in TypeScript #490 ))@hshoff @schillerk @milesj @kristw @Rudeg