Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typescript(vx-stats): re-write package in TypeScript #570

Merged
merged 5 commits into from
Dec 30, 2019
Merged

typescript(vx-stats): re-write package in TypeScript #570

merged 5 commits into from
Dec 30, 2019

Conversation

williaster
Copy link
Collaborator

@williaster williaster commented Dec 30, 2019 •
edited
Loading

🚀 Enhancements

This PR builds off #488 which introduces Typescript build config, and re-writes the @vx/stats package in TypeScript. It closes #562.

💥 Breaking Changes

  • This PR introduces React.Fragments, which requires bumping the peerDep for react to ^16.3.0-0
  • The following changes were made to the package directory structure which will affect deep import paths of components (importing from the index is unchanged):
    • src/violinplot/ViolinPlot.jsx => src/ViolinPlot.tsx
    • src/boxplot/BoxPlot.jsx => src/BoxPlot.tsx

Tests

  • CI
  • generates .d.ts files
  • functional via /stats demo

cc @hshoff @schillerk @kristw @Rudeg

@williaster williaster added this to the v0.0.193 milestone Dec 30, 2019
@williaster williaster merged commit 51f5cc3 into master Dec 30, 2019
@williaster williaster deleted the chris--ts-stats branch December 30, 2019 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
💥 breaking changes 🚀enhancement 🤖 typescript
Projects
None yet
Milestone
v0.0.193
Development

Successfully merging this pull request may close these issues.

Re-write @vx/stats in TypeScript
1 participant
@williaster