Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor code for domain driven design #3

Closed
hsoj opened this issue Oct 7, 2022 · 0 comments
Closed

Refactor code for domain driven design #3

hsoj opened this issue Oct 7, 2022 · 0 comments

Comments

@hsoj
Copy link
Owner

hsoj commented Oct 7, 2022

The code is currently laid out with all of the modules contained within the primary package and should be available from the correct domain instead. Additionally, the pattern used for the entry point is an older style, which should be updated to comply with modern Python application patterns.
hsoj added a commit that referenced this issue Oct 7, 2022
@hsoj
Working on getting the pre-commit hook working with the pylint tool.
1abacef 
gh-#3
hsoj added a commit that referenced this issue Oct 7, 2022
@hsoj
Renamed the dubilier.bot.cli main CLI group's name to not be
630685f 
redundant.  Added the call to the dubilier.bot.cli.main method in the
execution of the bot from CLI.

gh-#3
hsoj added a commit that referenced this issue Oct 8, 2022
@hsoj
Removing the old style of code so that it does not impact the testing.
393f8e7 
Adding testing for the current methods that exist.  Updated how tests
are executed as well as expanded the tooling used within the pre commit.

gh-#3
hsoj added a commit that referenced this issue Oct 8, 2022
@hsoj
Added CLI command for running the bot along with it's tests.
e2f3972 
gh-#3
hsoj added a commit that referenced this issue Oct 8, 2022
@hsoj
Ignoring the discord typing stubs as they do not exist. Extending the
d0a0a2f 
required Intents object to get around linting issues.  Added test to
ensure that the bot property is the proper instance type.

gh-#3
hsoj added a commit that referenced this issue Oct 8, 2022
@hsoj
Added functionality to the dubilier.bot.discord.Daemon object to run the
e6d41dc 
daemon and tests surrounding it.

gh-#3
hsoj added a commit that referenced this issue Oct 8, 2022
@hsoj
Implementing the dubilier.bot.discord.Daemon into the CLI run command.
9400468 
Updated tests to mock the underlining run method's exit status code.

gh-#3
hsoj added a commit that referenced this issue Oct 8, 2022
@hsoj
Introducing a bad pattern for getting submodule CLI commands included
1aa7db3 
into the main command chain.  Updated tests to comply with the
refactoring.

gh-#3
hsoj added a commit that referenced this issue Oct 8, 2022
@hsoj
Added sqlite session property for communicating with the database.
49af037 
Modified tests to comply with changes.

gh-#3
hsoj added a commit that referenced this issue Oct 8, 2022
@hsoj
Adding in the base object to allow for bot commands to be easily
c017365 
created.

gh-#3
hsoj added a commit that referenced this issue Oct 8, 2022
@hsoj
Working on getting the pre-commit hook working with the pylint tool.
64000f8 
gh-#3
hsoj added a commit that referenced this issue Oct 8, 2022
@hsoj
Renamed the dubilier.bot.cli main CLI group's name to not be
82d7131 
redundant.  Added the call to the dubilier.bot.cli.main method in the
execution of the bot from CLI.

gh-#3
hsoj added a commit that referenced this issue Oct 8, 2022
@hsoj
Removing the old style of code so that it does not impact the testing.
30d85f6 
Adding testing for the current methods that exist.  Updated how tests
are executed as well as expanded the tooling used within the pre commit.

gh-#3
hsoj added a commit that referenced this issue Oct 8, 2022
@hsoj
Added CLI command for running the bot along with it's tests.
a1a9884 
gh-#3
hsoj added a commit that referenced this issue Oct 8, 2022
@hsoj
Ignoring the discord typing stubs as they do not exist. Extending the
a098242 
required Intents object to get around linting issues.  Added test to
ensure that the bot property is the proper instance type.

gh-#3
hsoj added a commit that referenced this issue Oct 8, 2022
@hsoj
Added functionality to the dubilier.bot.discord.Daemon object to run the
1d7fff4 
daemon and tests surrounding it.

gh-#3
hsoj added a commit that referenced this issue Oct 8, 2022
@hsoj
Implementing the dubilier.bot.discord.Daemon into the CLI run command.
5628dc9 
Updated tests to mock the underlining run method's exit status code.

gh-#3
hsoj added a commit that referenced this issue Oct 8, 2022
@hsoj
Introducing a bad pattern for getting submodule CLI commands included
067b260 
into the main command chain.  Updated tests to comply with the
refactoring.

gh-#3
hsoj added a commit that referenced this issue Oct 8, 2022
@hsoj
Added sqlite session property for communicating with the database.
027e8d0 
Modified tests to comply with changes.

gh-#3
hsoj added a commit that referenced this issue Oct 8, 2022
@hsoj
Adding in the base object to allow for bot commands to be easily
6fda31e 
created.

gh-#3
@hsoj hsoj closed this as completed Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hsoj