PR Feedback: Conver to use Sets

src/runMocha.js

@@ -9,18 +9,21 @@ const runMocha = ({ config, testPath, globalConfig }, workerCallback) => {
   class Reporter extends Mocha.reporters.Base {
     constructor(runner) {
       super(runner);
-      const tests = [];
-      const pending = [];
-      const failures = [];
-      const passes = [];
+      const tests = new Set();
+      const pending = new Set();
+      const failures = new Set();
+      const passes = new Set();
 
-      runner.on('test end', test => tests.push(test));
-      runner.on('pass', test => passes.push(test));
+      runner.on('test end', test => tests.add(test));
+      runner.on('pass', test => passes.add(test));
       runner.on('fail', (test, err) => {
         test.err = err;
-        failures.push(test);
+        failures.add(test);
+
+        // Ensure we include failing tests in our final set of tests.
+        tests.add(test);
       });
-      runner.on('pending', test => pending.push(test));
+      runner.on('pending', test => pending.add(test));
       runner.on('end', () => {
         try {
           workerCallback(

src/utils/toTestResult.js

@@ -13,21 +13,12 @@ const getFailureMessages = tests => {
   return failureMessages.length ? failureMessages : null;
 };
 
-const toTestResult = ({ stats, tests, failures, jestTestPath, coverage }) => {
-  const effectiveTests = tests;
-
-  // Merge failed tests that don't exist in the tests array so that we report
-  // all tests even if an error occurs in a beforeEach block.
-  failures.forEach(test => {
-    if (!tests.some(t => t === test)) {
-      tests.push(test);
-    }
-  });
-
+const toTestResult = ({ stats, tests: testsSet, jestTestPath, coverage }) => {
+  const tests = Array.from(testsSet);
   return {
     coverage,
     console: null,
-    failureMessage: getFailureMessages(effectiveTests),
+    failureMessage: getFailureMessages(tests),
     numFailingTests: stats.failures,
     numPassingTests: stats.passes,
     numPendingTests: stats.pending,
@@ -47,7 +38,7 @@ const toTestResult = ({ stats, tests, failures, jestTestPath, coverage }) => {
     sourceMaps: {},
     testExecError: null,
     testFilePath: jestTestPath,
-    testResults: effectiveTests.map(test => {
+    testResults: tests.map(test => {
       return {
         ancestorTitles: [],
         duration: test.duration / 1000,