Serializer.convertShort: removed #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replaced by 'C.pack . show' The Haskell foreign import of cshortToString had wrong parameter type Int. It should have been CShort. But this silently wraps around any integer in a PDF document at 32767. I tried to replace 'short' by 'long', but this does not solve the problem. In order to prevent silent wrap-around I would have to add a check and an 'error', but the check would have to work for all possible sizes of 'Int' and 'CLong' and would certainly require to convert from and to Integer at some point. This is all error-prone and unsafe. In contrast to that, 'show' is simple and safe.
The C function was vulnerable to buffer overflows. Remove cbits completely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaced by 'C.pack . show'
The Haskell foreign import of cshortToString had wrong parameter type Int. It should have been CShort.
But this silently wraps around any integer in a PDF document at 32767.
I tried to replace 'short' by 'long', but this does not solve the problem. In order to prevent silent wrap-around
I would have to add a check and an 'error',
but the check would have to work for all possible sizes of 'Int' and 'CLong' and would certainly require to convert from and to Integer at some point. This is all error-prone and unsafe.
In contrast to that, 'show' is simple and safe.
Fixed bug #14.