Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make ZeynepJS compatible with Cash library #14

Merged
merged 2 commits into from
Jan 15, 2022
Merged

feat: Make ZeynepJS compatible with Cash library #14

merged 2 commits into from
Jan 15, 2022

Conversation

aimeos
Copy link
Contributor

@aimeos aimeos commented Jan 14, 2022

cash-dom is a lightweight jQuery alternative offering a similary API like jQuery but is using modern browser features where available: https://github.com/fabiospampinato/cash

cash-dom is a lightweight jQuery alternative offering a similary API like jQuery but is using modern browser features where available:
https://github.com/fabiospampinato/cash
Copy link
Owner

@hsynlms hsynlms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

The last thing to do to support cash is passing the library as the first argument in here:
https://github.com/hsynlms/zeynepjs/blob/master/src/zeynep.js#L187

Like:

(window.jQuery || window.cash, 'zeynep')

And please follow the contributing guide for further commits. I prefer conventional commits, and it's more fun :)

src/zeynep.js Outdated Show resolved Hide resolved
src/zeynep.js Outdated Show resolved Hide resolved
src/zeynep.js Outdated Show resolved Hide resolved
@aimeos aimeos changed the title Make compatible with Cash library feat: Make compatible with Cash library Jan 14, 2022
@aimeos aimeos changed the title feat: Make compatible with Cash library feat: Make ZeynepJS compatible with Cash library Jan 14, 2022
@aimeos
Copy link
Contributor Author

aimeos commented Jan 14, 2022

@hsynlms Done

@hsynlms
Copy link
Owner

hsynlms commented Jan 15, 2022

@aimeos thanks.

Btw, conventional commits are all about commit messages, not about issue titles ;)

@hsynlms hsynlms merged commit bfbad46 into hsynlms:master Jan 15, 2022
@hsynlms
Copy link
Owner

hsynlms commented Jan 15, 2022

Shipped with version 2.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants