Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Held components block error reports for later components #165

Closed
JoshKarpel opened this issue Jul 22, 2019 · 0 comments · Fixed by #171
Closed

Held components block error reports for later components #165

JoshKarpel opened this issue Jul 22, 2019 · 0 comments · Fixed by #171
Assignees
@JoshKarpel
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@JoshKarpel
Copy link
Contributor

When you try to iterate over error reports from a map that has a mix of held and errored components, the iteration will raise a MapComponentHeld exception when it hits a held component. This is not intuitive and makes it hard to look at error reports.

Solution: the internal iteration in Map.error_reports() should ignore held components.
@JoshKarpel JoshKarpel added bug Something isn't working good first issue Good for newcomers labels Jul 22, 2019
@JoshKarpel JoshKarpel self-assigned this Jul 22, 2019
JoshKarpel added a commit that referenced this issue Jul 26, 2019
@JoshKarpel
resolve #165
27c1277
@JoshKarpel JoshKarpel mentioned this issue Jul 26, 2019
Merged
JoshKarpel added a commit that referenced this issue Jul 29, 2019
@JoshKarpel
v0.4.2 (#171)
66f95c0 
* resolve #168 
* resolve #169
* resolve #165
* resolve #173
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshKarpel JoshKarpel

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v0.4.2 htcondor/htmap
1 participant
@JoshKarpel