Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Late materialization improvements #181

Merged
merged 9 commits into from
Sep 23, 2019
Merged

Late materialization improvements #181

merged 9 commits into from
Sep 23, 2019

Conversation

JoshKarpel
Copy link
Contributor

@JoshKarpel JoshKarpel commented Sep 21, 2019

This PR aims to address the various issues in #158

So far, we have an unmaterialized component state, that state has a CLI color, and maps with components in that state can proceed through the removal process.

@JoshKarpel JoshKarpel added bug Something isn't working enhancement New feature or request labels Sep 21, 2019
@JoshKarpel JoshKarpel self-assigned this Sep 21, 2019
@codecov
Copy link

codecov bot commented Sep 21, 2019

Codecov Report

Merging #181 into v0.5.0 will increase coverage by 1.31%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           v0.5.0     #181      +/-   ##
==========================================
+ Coverage   77.74%   79.06%   +1.31%     
==========================================
  Files          19       19              
  Lines        1937     2030      +93     
  Branches      310      339      +29     
==========================================
+ Hits         1506     1605      +99     
+ Misses        359      358       -1     
+ Partials       72       67       -5
Impacted Files Coverage Δ
htmap/cli.py 60.25% <ø> (+2.78%) ⬆️
htmap/maps.py 79.53% <ø> (ø) ⬆️
htmap/state.py 95.27% <87.5%> (+1.36%) ⬆️
htmap/options.py 85.2% <0%> (+1.96%) ⬆️
htmap/tags.py 79.48% <0%> (+5.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 471446b...9da2e66. Read the comment docs.

@JoshKarpel JoshKarpel added the cli Related to the CLI label Sep 21, 2019
@JoshKarpel JoshKarpel merged commit 595b46d into v0.5.0 Sep 23, 2019
@JoshKarpel JoshKarpel deleted the late-materialization branch September 23, 2019 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cli Related to the CLI enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant