-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shared Delivery #200
Shared Delivery #200
Conversation
Codecov Report
@@ Coverage Diff @@
## v0.6.0 #200 +/- ##
=====================================
- Coverage 78% 78% -1%
=====================================
Files 19 19
Lines 1964 1967 +3
Branches 315 315
=====================================
Hits 1537 1537
- Misses 361 363 +2
- Partials 66 67 +1
|
I am curious, why don't you autobuild a conda package and upload it? Its not a big deal |
I'm actually not very familiar with the conda-forge ecosystem - I think @duncanmmacleod set up https://github.com/conda-forge/htmap-feedstock. Not sure how to update it. If you need this branch right now, you can uninstall the conda-forge package and |
I will wait for the official release because i need to get it blessed internally. |
The conda-forge organisation handles all of its own builds, mainly to maximise interoperability of packages in the ecosystem. Once the new tarball hits PyPI, the conda-forge bot will automatically open a PR to update the conda recipe, which I can then merge. I am happy to add @JoshKarpel to the maintainers list, so that nobody is dependent upon me. |
That'd be great, @duncanmmacleod - I can add merging that PR to our release process docs as well. |
when do you plan to merge it? I ask because I have some people who want to test the functionality. |
@keith6014 Unfortunately I'm not sure - there's a bit of a backlog of things I'd like to do for v0.6.0 (https://github.com/htcondor/htmap/projects/7) that I haven't gotten to yet, and I've got some other things on my plate at the moment. I can probably push some of them and get v0.6.0 out the door sooner, but I doubt it would be this week. Is it possible for you to use the quick fix in #195 for the moment and switch to the "real" shared delivery when v0.6.0 releases? |
yes. totally. I will use the quickfix. Thanks for the great effort and intuative library. |
…anup for some tests that need held components
007407d
to
aa53f3e
Compare
This PR adds a new delivery method,
shared
, which packs up the options required to run HTMap with a Python installation that is shared between submit and execute (e.g., a Python installation stored on a shared filesystem).This PR will resolve #195 and #198