Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared Delivery #200

Merged
merged 10 commits into from
Apr 29, 2020
Merged

Shared Delivery #200

merged 10 commits into from
Apr 29, 2020

Conversation

JoshKarpel
Copy link
Contributor

This PR adds a new delivery method, shared, which packs up the options required to run HTMap with a Python installation that is shared between submit and execute (e.g., a Python installation stored on a shared filesystem).

This PR will resolve #195 and #198

@JoshKarpel JoshKarpel added enhancement New feature or request delivery labels Mar 24, 2020
@JoshKarpel JoshKarpel self-assigned this Mar 24, 2020
@codecov
Copy link

codecov bot commented Mar 24, 2020

Codecov Report

Merging #200 into v0.6.0 will decrease coverage by 0%.
The diff coverage is 88%.

@@          Coverage Diff          @@
##           v0.6.0   #200   +/-   ##
=====================================
- Coverage      78%    78%   -1%     
=====================================
  Files          19     19           
  Lines        1964   1967    +3     
  Branches      315    315           
=====================================
  Hits         1537   1537           
- Misses        361    363    +2     
- Partials       66     67    +1     
Impacted Files Coverage Δ
htmap/options.py 84% <87%> (-1%) ⬇️
htmap/__init__.py 100% <100%> (ø)
htmap/state.py 91% <0%> (-2%) ⬇️

@keith6014
Copy link

I am curious, why don't you autobuild a conda package and upload it? Its not a big deal

@JoshKarpel
Copy link
Contributor Author

I'm actually not very familiar with the conda-forge ecosystem - I think @duncanmmacleod set up https://github.com/conda-forge/htmap-feedstock. Not sure how to update it.

If you need this branch right now, you can uninstall the conda-forge package and pip install git+https://github.com/htcondor/htmap.git@shared-delivery.

@keith6014
Copy link

I'm actually not very familiar with the conda-forge ecosystem - I think @duncanmmacleod set up https://github.com/conda-forge/htmap-feedstock. Not sure how to update it.

If you need this branch right now, you can uninstall the conda-forge package and pip install git+https://github.com/htcondor/htmap.git@shared-delivery.

I will wait for the official release because i need to get it blessed internally.

@duncanmmacleod
Copy link
Contributor

The conda-forge organisation handles all of its own builds, mainly to maximise interoperability of packages in the ecosystem.

Once the new tarball hits PyPI, the conda-forge bot will automatically open a PR to update the conda recipe, which I can then merge. I am happy to add @JoshKarpel to the maintainers list, so that nobody is dependent upon me.

@JoshKarpel
Copy link
Contributor Author

That'd be great, @duncanmmacleod - I can add merging that PR to our release process docs as well.

@keith6014
Copy link

That'd be great, @duncanmmacleod - I can add merging that PR to our release process docs as well.

when do you plan to merge it? I ask because I have some people who want to test the functionality.

@JoshKarpel
Copy link
Contributor Author

@keith6014 Unfortunately I'm not sure - there's a bit of a backlog of things I'd like to do for v0.6.0 (https://github.com/htcondor/htmap/projects/7) that I haven't gotten to yet, and I've got some other things on my plate at the moment. I can probably push some of them and get v0.6.0 out the door sooner, but I doubt it would be this week. Is it possible for you to use the quick fix in #195 for the moment and switch to the "real" shared delivery when v0.6.0 releases?

@keith6014
Copy link

@keith6014 Unfortunately I'm not sure - there's a bit of a backlog of things I'd like to do for v0.6.0 (https://github.com/htcondor/htmap/projects/7) that I haven't gotten to yet, and I've got some other things on my plate at the moment. I can probably push some of them and get v0.6.0 out the door sooner, but I doubt it would be this week. Is it possible for you to use the quick fix in #195 for the moment and switch to the "real" shared delivery when v0.6.0 releases?

yes. totally. I will use the quickfix. Thanks for the great effort and intuative library.
take your time. the quickfix is good enough for us.

@JoshKarpel JoshKarpel marked this pull request as ready for review April 29, 2020 03:33
@JoshKarpel JoshKarpel merged commit 33c73d3 into v0.6.0 Apr 29, 2020
@JoshKarpel JoshKarpel deleted the shared-delivery branch April 29, 2020 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delivery enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants