Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better os compatibility #21

Merged
merged 10 commits into from
Jul 24, 2023
Merged

Better os compatibility #21

merged 10 commits into from
Jul 24, 2023

Conversation

htjb
Copy link
Owner

@htjb htjb commented Jul 11, 2023

Resolving #8 and some install issues on Windows hopefully. Also adding tests for the different OS.

@htjb htjb changed the title Better os compat Better os compatibility Jul 11, 2023
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (dce5bb0) 98.26% compared to head (68598b5) 98.26%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #21   +/-   ##
=======================================
  Coverage   98.26%   98.26%           
=======================================
  Files          10       10           
  Lines         635      635           
=======================================
  Hits          624      624           
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@htjb
Copy link
Owner Author

htjb commented Jul 24, 2023

Okay, I now have working tests on windows, mac and linux. Hopefully the windows pip install should be fixed too (I was having issues with the function that parses the readme in setup.py to get the version number).

Having some issues on mac and windows with tkinter.

@htjb
Copy link
Owner Author

htjb commented Jul 24, 2023

Hmm going to move tkinter setup to a separate issue since it looks complicated!

@htjb htjb merged commit fd89b48 into master Jul 24, 2023
@htjb htjb deleted the better_os_compat branch July 24, 2023 14:54
This was referenced Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants