Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix eaten unicode whitespaces issue #203

Merged
merged 1 commit into from
Jun 1, 2020

Conversation

real-artswan
Copy link
Contributor

It drops leading/trailing Unicode white-spaces (like non-breakable space) if they're not HTML-encoded.
It is fixed by testing for space by "\s" regexp excluding new line and tab characters.

@KillyMXI
Copy link
Member

Thank you

@KillyMXI
Copy link
Member

KillyMXI commented Jun 1, 2020

By the way. @real-artswan I noticed you've removed a certain step from package.json scripts in your fork after this PR.

I'm curious to know why.
I might switch it from prepare to prepublishOnly and I'd be happy to have something to support that.

@minaseem
Copy link

minaseem commented Jun 1, 2020

By when can we expect this fix to be released?

@KillyMXI
Copy link
Member

KillyMXI commented Jun 1, 2020

There are still some important issues to address before version 6.0 will be ready.

Good news is I'm finally back to work on it.
Bad news is the scope of things to address has grown.

If nothing else happens, it should be done in less than a week. But I think I've said the same thing few times already, to then break those estimates.

@minaseem
Copy link

minaseem commented Jun 1, 2020

Thanks a lot for the update

@real-artswan
Copy link
Contributor Author

@KillyMXI, while the fix is not in the mainstream I had to point my project to use my fork. It runs tests on every install but, unfortunately, tests don't work for one guy in my team so I had to disable it as a hot fix. I suspect that the reason is a combination of linebreaks in the fixture file and Windows but I didn't investigate a lot

@minaseem
Copy link

@KillyMXI, Any plans on the release?

Waiting on this :)

Thanks!

@KillyMXI
Copy link
Member

I'm wrapping things up for #200.
I was hoping to ship with another important improvement, but that turns into a major refactoring I don't have time for.
So it will be done sooner rather than later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants