Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove simpletree from the package #45

Closed
wants to merge 7 commits into from

Conversation

ambv
Copy link
Member

@ambv ambv commented May 6, 2013

The default tree builder is now etree. I also added an "implementation" attribute to the TreeBuilder API so you can select the correct ElementTree if you have to access it. In related news, I started a change log, to be filled out before releasing 1.0 proper.

@gsnedders
Copy link
Member

And merged in 96da7f5.

@gsnedders gsnedders closed this May 7, 2013
@ambv ambv deleted the die_simpletree branch May 7, 2013 20:14
@jsocol
Copy link

jsocol commented May 23, 2013

Is there any discussion of why this change was made anywhere? I wasn't able to find anything on html5lib-discuss.

@jgraham
Copy link
Member

jgraham commented May 23, 2013

The discussion was on IRC. Basically the feeling was that simpletree isn't production quality and there is not enough benefit in maintaining our own tree format just for testing.

@gsnedders
Copy link
Member

And related to that, it has proved at several points to be quite a lot of work to maintain, when really it serves almost nobody: we support two tree APIs in the stdlib which should suffice in general.

@jsocol
Copy link

jsocol commented May 24, 2013

Well, I'll disagree with "when really it serves almost nobody" because it was incredibly helpful in Bleach, and getting around the removal (mozilla/bleach#94) is going to pin me and bleach users to 0.96 for a while. I understand the reasons, but it would be great to document hugely-API-breaking changes' decision process.

@gsnedders
Copy link
Member

Well, what do you gain by using simpletree instead of e.g., minidom or ElementTree? I don't think there's any case in which simpletree is the right choice — thus "it serves almost nobody".

@jezdez
Copy link

jezdez commented May 26, 2013

This also breaks django_compressor in a non-trivial way: django-compressor/django-compressor#405

@ambv
Copy link
Member Author

ambv commented May 27, 2013

django-compressor/django-compressor#405 is fixed, switched to using the default etree builder and walker.

@jezdez
Copy link

jezdez commented May 27, 2013

Thanks, @ambv!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants