simpletree TreeWalker removed in html5lib 1.0b1

[gavinwahl]

The simpletree walker, used by bleach, was removed in html5lib 1.0b1. See the changelog: https://pypi.python.org/pypi/html5lib#change-log

Bleach fails with:

Traceback (most recent call last):
  File "/srv/python-environments/8266ee6461a534ae/local/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/home/gavin/bleach/bleach/tests/test_unicode.py", line 27, in test_mixed
    clean(u'Домашняяヘルプとチュートリアル'))
  File "/home/gavin/bleach/bleach/__init__.py", line 111, in clean
    return _render(parser.parseFragment(text))
  File "/home/gavin/bleach/bleach/__init__.py", line 306, in _render
    return force_unicode(_serialize(tree))
  File "/home/gavin/bleach/bleach/__init__.py", line 313, in _serialize
    stream = walker(domtree)
TypeError: 'NoneType' object is not callable

Because html5lib.treewalkers.getTreeWalker('simpletree') returns None.

[joshcartme]

+1, I was about to post this same issue myself.

[jsocol]

Thanks guys, I'll take a look this weekend.

---

Sent from my phone, please excuse the occasional typo.

On May 17, 2013, at 5:43 PM, joshcartme notifications@github.com wrote:

+1, I was about to post this same issue myself.

—
Reply to this email directly or view it on GitHub.

[stephenmcd]

Could we get a patch release for bleach that just pins the max html5lib version for now?

[jsocol]

I can try to get that out and on pypi late tonight.

---

Sent from my phone, please excuse the occasional typo.

On May 17, 2013, at 5:55 PM, Stephen McDonald notifications@github.com wrote:

Could we get a patch release for bleach that just pins the max html5lib version for now?

—
Reply to this email directly or view it on GitHub.

[stephenmcd]

Thanks a lot James.

FWIW this currently breaks https://github.com/stephenmcd/mezzanine which pins bleach but doesn't pin html5lib.

[stephenmcd]

We're going to do a patch release of Mezzanine that pins html5lib, so no rush.

Sorry about the noise.

[jsocol]

I am dumb and put 0.9.5 in the requirements.txt and docs/index.rst files. But setup.py has 0.95, which is correct, so tag v1.2.2 will install. The latest master has the correct requirements.

[mdxs]

Can be considered closed in 98a7c8e (see #101 and #111 and also note the remark in #111 about the html5lib version numbering changes from 1.0b back to 0.99 series).

[jsocol]

Yep, thanks @mdxs!