Remove LXC special handling for the CPU count #1197
Conversation
LXC shows the real host CPU ids but can be limited in configuration as to which cores are used. Still the sysfs files are visible and the CPUs (stay) marked online. We will need to parse /sys/devices/system/cpu/online to follow LXC's logic. Revert for now until we can come up with a better handling of the LXC hacks. Cf. issue htop-dev#1195 Essentially reverting 33973f7 and 0d53245 (htop-dev#993, htop-dev#995)
|
Applying this against 3.2.2 tarball, that does indeed go back to the old behavior.
|
|
Actually if I apply this patch to htop 3.2.2, I get the WRONG number of cpus in the htop output. Inside a LXC container with a cgroup limit to 2 cpus. htop 3.2.2 compiled from the release tar.xz:
htop 3.2.2 with this patch added:
To me this looks wrong. Why are now all cpus showing up again when the cgroup limit is in place? |
|
@Napsty Two reasons.
|
LXC shows the real host CPU ids but can be limited in configuration as to which cores are used. Still the sysfs files are visible and the CPUs (stay) marked online. We will need to parse
/sys/devices/system/cpu/online to follow LXC's logic. Revert for now until we can come up with a better handling of the LXC hacks.
Cf. issue #1195
Essentially reverting 33973f7 and 0d53245 (#993, #995)