Force rebuild of display table after removals #1519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Table_removeIndex() needs to be called with care, e.g. Vector_compact() needs to be called afterwards. Do no call by accident from external code.
Table_compact() is called after Table_cleanupRow(), which might remove rows, which are still referenced by the display table. Set needsSort to true so that Table_updateDisplayList() always performs a rebuild and does access removed rows. Fixes: htop-dev#1517
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Table_compact() is called after Table_cleanupRow(), which might remove
rows, which are still referenced by the display table. Set needsSort to
true so that Table_updateDisplayList() always performs a rebuild and
does access removed rows.
Fixes: #1517