Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Your theme's demo is not working on the Hugo Themes website. #53

Closed
onedrawingperday opened this issue Nov 8, 2018 · 6 comments
Closed

Your theme's demo is not working on the Hugo Themes website. #53

onedrawingperday opened this issue Nov 8, 2018 · 6 comments

Comments

@onedrawingperday
Copy link

@onedrawingperday onedrawingperday commented Nov 8, 2018

Hello @htr3n

I saw in your theme's README that since version 0.2 the main styles were refactored and redeveloped using SCSS.

However you have not committed the generated resources of your theme and as a result your theme's demo fails to generate on the Hugo website.

To fix this issue please have a look at the updated README of Hugo Themes: https://github.com/gohugoio/hugoThemes#resources You need to commit the /resources/ directory and its contents in your theme's repository.

If you have any questions do not hesitate to ask me or @digitalcraftsman

@htr3n

This comment has been minimized.

Copy link
Owner

@htr3n htr3n commented Nov 9, 2018

@onedrawingperday Thanks for the heads-up. The thing is per PR #45, hyde-hyde is now can directly use SCSSs within HTML templates. Thus, the generated CSSs were deleted (in the same PR) to ensure hyde-hyde works normally with SCSSs and avoid any confusions between the unused CSSs and SCSSs when someone want to customize the theme.

I will have a deeper look and try to fix it ASAP. Any hints would be truly appreciated.

htr3n added a commit that referenced this issue Nov 9, 2018
@htr3n

This comment has been minimized.

Copy link
Owner

@htr3n htr3n commented Nov 9, 2018

@onedrawingperday I have just fixed hyde-hyde by adding resource per the guide that you referred. I hope the demo works fine now. Please let me know if anything else need to fix too. Thanks a lot for your time and effort.

@onedrawingperday

This comment has been minimized.

Copy link
Author

@onedrawingperday onedrawingperday commented Nov 9, 2018

@htr3n I had a look at commit 56d21df and the associated PR.

First of all you need to commit the generated CSS for all HTML templates, meaning that locally you will have to enable all conditionals.

Second for your Hugo Pipes Assets you need to use .RelPermalink in your templates and you need to replace all instances of .Permalink see: https://github.com/gohugoio/hugoThemes#common-permalink-issues

PS I see that you just made a new commit but the Resources will be missing from your Demo because as I said above you need to use .RelPermalink in the templates.

@htr3n

This comment has been minimized.

Copy link
Owner

@htr3n htr3n commented Nov 9, 2018

@onedrawingperday I've just realized the issues right after committing ;) I'm working on it. Thanks.

@htr3n

This comment has been minimized.

Copy link
Owner

@htr3n htr3n commented Nov 10, 2018

@onedrawingperday: I fixed the templates with .RelPermalink and even cloned the hugoTheme Github repos to my local machine to test hyde-hyde. The demo seems to show up and work again.

Please let me know if there are still some issues. Thanks for your patience.

@onedrawingperday

This comment has been minimized.

Copy link
Author

@onedrawingperday onedrawingperday commented Nov 10, 2018

@htr3n Thank you very much! I confirm the fix.

The demo will work again the next time themes are updated on the Hugo website.

CC / @digitalcraftsman

cyberflamingo pushed a commit to cyberflamingo/hyde-hyde that referenced this issue Jul 30, 2019
cyberflamingo pushed a commit to cyberflamingo/hyde-hyde that referenced this issue Jul 30, 2019
cyberflamingo pushed a commit to cyberflamingo/hyde-hyde that referenced this issue Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.