Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSocket support #11

Closed
zefhemel opened this issue Sep 9, 2010 · 8 comments
Closed

WebSocket support #11

zefhemel opened this issue Sep 9, 2010 · 8 comments

Comments

@zefhemel
Copy link

zefhemel commented Sep 9, 2010

Is node-http-proxy supposed to support websockets? It seems that websocket are not passed through (according to my testing), is that correct or do I have to configure something differently?

@tmpvar
Copy link

tmpvar commented Sep 9, 2010

From what I've seen it should work, although we probably should have some tests for proof

@Marak
Copy link
Contributor

Marak commented Sep 9, 2010

i would think it should work as well, but we have no tests in place for websockets.

we are working out cranking out the new version, does anyone want to step up and do a simple vows websocket test?

@zefhemel
Copy link
Author

Maybe it should work, but according to my testing it does not (I just upgraded to 0.3.0, same result). The server behind the proxy never gets the websocket connection (I'm using socket.io here).

@Marak
Copy link
Contributor

Marak commented Sep 10, 2010

i've been talking to the socket.io author and i think he's gonna help getting some vows tests for websockets / socket.io

if you can create the tests for websockets we can make them pass. if not, rauchg should have something posted soon.

@Marak
Copy link
Contributor

Marak commented Sep 15, 2010

looks like the fork @ http://github.com/donnerjack13589/node-http-proxy might be a fix for this. has unit tests as well.

@Marak
Copy link
Contributor

Marak commented Dec 1, 2010

Is this merged yet? If so why not?

@Marak
Copy link
Contributor

Marak commented Dec 1, 2010

@indexzero
Copy link
Contributor

Fixed in b0b0183. Needs some more tests before I release v0.5.0, but in the meantime checkout the working demo here: https://github.com/nodejitsu/node-http-proxy/blob/v0.5.0/examples/web-socket-proxy.js

yawnt added a commit that referenced this issue Sep 15, 2013
[fix] add ability to proxy websockets over HTTPS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants