Notify the Sender that the Encoder has been dropped #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbr
force-pushed
the
handle-dropped-encoder
branch
from
4a86282
to
d2f1aa6
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the signature of Sender::send to return a Result that indicates whether the send was successful, allowing tide or other consumers to use
?to break out of a send loop.This PR replaces pin-project-lite with pin-project in order to use pinned drop. A shared
Arc<AtomicBool>is the concurrency primitive, which seemed like the simplest thing that could possibly work.This addresses http-rs/tide#591 in conjunction with http-rs/tide#598