-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hyper: re-use internal client, impl Default #45
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fishrock123
force-pushed
the
hyper-improvements
branch
3 times, most recently
from
September 22, 2020 18:48
349d385
to
9ccba5c
Compare
Edit: actually nightly broke: rust-lang/rust#77089 That docs failure is not our own but rather async-std's
|
Fishrock123
changed the title
hyper: Clone & Default, re-use internal client
hyper: re-use internal client, impl Default
Sep 24, 2020
- Makes HyperClient impl Clone and Default - Re-uses the internal hyper client for pooling and alloc efficiency - Adds HyperClient::from_client() - Always uses the HttpsConnector (has internal http fallback) Required for hyper-client in Surf: http-rs/surf#234
Avoid leaking Hyper generics into HttpClient by hiding it behind a dynamic trait object pointer.
Fishrock123
force-pushed
the
hyper-improvements
branch
from
September 25, 2020 20:05
14deef8
to
e2c9f00
Compare
ok well, since this is feature flagged anyways I'm just gona merge it, since I want it for lambda. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clone andDefaultRequired for hyper-client in Surf:
http-rs/surf#234