fix: properly check if connections can be recycled #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fishrock123
force-pushed
the
fix-h1-connection-pooling
branch
4 times, most recently
from
afb3e3a
to
70d1805
Compare
|
Ok only wasm is failing here for unrelated reasons (see https://http-rs.zulipchat.com/#narrow/stream/261408-general/topic/wasm.20support/near/229125496). Going to merge and release. |
Checks `poll_read`'s status directly, so that we can ensure a socket read actually happens, and then immediately continue if we get `Poll::Pending`. Related to http-rs#75
This avoids unnecessarily registering with the waker when we aren't going to poll until Ready. Thanks to Kestrer on discord.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #75