Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Body should be constructed around a Read instead of a BufRead #297

Open
jbr opened this issue Dec 14, 2020 · 0 comments · May be fixed by #298
Open

Body should be constructed around a Read instead of a BufRead #297

jbr opened this issue Dec 14, 2020 · 0 comments · May be fixed by #298
Labels
semver-major This change requires a semver major change
Milestone
3.0

Comments

@jbr
Copy link
Member

jbr commented Dec 14, 2020

this will require dropping the BufRead implementation for Body, Request, and Response as well as changing the Body::from_reader signature — people can wrap Reads with async_std::io::BufReaders if they need BufRead behavior
@jbr jbr added the semver-major This change requires a semver major change label Dec 14, 2020
@jbr jbr added this to the 3.0 milestone Dec 14, 2020
@jbr jbr linked a pull request Dec 14, 2020 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
semver-major This change requires a semver major change
Projects
None yet
Milestone
3.0
Development

Successfully merging a pull request may close this issue.

construct bodies from impl Read instead of impl BufRead http-rs/http-types
1 participant
@jbr