Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

construct bodies from impl Read instead of impl BufRead #298

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jbr
Copy link
Member

@jbr jbr commented Dec 14, 2020

closes #297

do not merge until 3.0

@jbr jbr added the semver-major This change requires a semver major change label Dec 14, 2020
@jbr jbr added this to the 3.0 milestone Dec 14, 2020
@yoshuawuyts yoshuawuyts marked this pull request as draft December 18, 2020 14:26
@yoshuawuyts
Copy link
Member

Marked as draft so we physically can't merge until 3.0.

Copy link
Member

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, but otherwise good!

src/body.rs Outdated Show resolved Hide resolved
@Fishrock123
Copy link
Member

What's this waiting on?

@jbr
Copy link
Member Author

jbr commented Feb 12, 2021

I think this one should probably be a draft. I'm not certain this is the right choice for async-h1, but can throw together a PR branch for async-h1 that uses this branch and see what the consequences are

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-major This change requires a semver major change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Body should be constructed around a Read instead of a BufRead
3 participants