Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection pooling in Client / HttpClient #224

Closed
Fishrock123 opened this issue Sep 7, 2020 · 3 comments
Closed

Connection pooling in Client / HttpClient #224

Fishrock123 opened this issue Sep 7, 2020 · 3 comments

Comments

@Fishrock123
Copy link
Member

Kat Marchán (@zkat) did a bunch of work on this in https://github.com/orogene/orogene/blob/main/crates/oro-client/src/http_client/mod.rs and gave us permission to re-use specifically the pooling client code for Surf.

This needs to be implemented in http-client but might as well be tracked here.

Going to try to get to this this week. Would be easier (in a sense) if #217 was agreed upon and I didn't have to try to make this generic across all clients first-go.

@Fishrock123
Copy link
Member Author

So turns out Isahc does indeed have connection pooling of its own but I suspect we may not be making use of it. See https://docs.rs/isahc/0.9.8/isahc/struct.HttpClient.html

@Fishrock123
Copy link
Member Author

When #234 lands, the hyper-client will also have connection pooling built in.

@Fishrock123
Copy link
Member Author

http-client 6.3.0 (a minor upgrade, cargo update), includes connection pooling.

@Fishrock123 Fishrock123 moved this from To-Do to Merged / Completed in Surf default to async-h1 Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Surf default to async-h1
Merged / Completed
Development

No branches or pull requests

1 participant