Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation: Add "Getting Started" section to Readme and lib.rs. #445

Merged
merged 2 commits into from
Apr 22, 2020
Merged

Documentation: Add "Getting Started" section to Readme and lib.rs. #445

merged 2 commits into from
Apr 22, 2020

Conversation

Walther
Copy link
Contributor

@Walther Walther commented Apr 20, 2020 •
edited
Loading

Mentions async-std and its features = ["attributes"] clearly.
Fixes #431

Let me know if there are any wording changes or something else you'd want to improve in this PR!

@Walther
Documentation: Add "Getting Started" section to Readme and lib.rs.
c7b9050 
Mentions `async-std` and its `features = ["attributes"]` clearly.
yoshuawuyts
yoshuawuyts approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Small nit, but otherwise 💯

src/lib.rs Outdated Show resolved Hide resolved
@yoshuawuyts yoshuawuyts merged commit e74cb4c into http-rs:master Apr 22, 2020
@Walther Walther deleted the 431-documentation-mention-features-attributes branch April 22, 2020 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation: mention features = ["attributes"]
2 participants
@Walther @yoshuawuyts