Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include instructions on running examples in README #460

Merged
merged 1 commit into from
Apr 23, 2020
Merged

Include instructions on running examples in README #460

merged 1 commit into from
Apr 23, 2020

Conversation

jbr
Copy link
Member

@jbr jbr commented Apr 23, 2020

also updates the hello world example in the markdown to return a Result

yoshuawuyts
yoshuawuyts approved these changes Apr 23, 2020
View reviewed changes
Copy link
Member

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@yoshuawuyts yoshuawuyts merged commit c61d477 into http-rs:master Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbr @yoshuawuyts