Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add elapsed field to logger #98

Closed
wants to merge 1 commit into from
Closed

add elapsed field to logger #98

wants to merge 1 commit into from

Conversation

leaxoy
Copy link
Contributor

@leaxoy leaxoy commented Nov 30, 2018

No description provided.

@KodrAus
Copy link
Contributor

KodrAus commented Dec 3, 2018

Hi @leaxoy! 👋

It's definitely useful to be able to collect timings about how long a piece of middleware takes to execute, but in my opinion this is best solved through some kind of contextual logging where we can choose what blocks of code to wrap for timings.

@KodrAus KodrAus mentioned this pull request Dec 3, 2018
@leaxoy
Copy link
Contributor Author

leaxoy commented Dec 3, 2018

Wrap the user logic maybe useful. Then we can add some code around RequestContext.next call with insert time field to Request.extensions, which can be used whenever it's needed.

@yoshuawuyts yoshuawuyts added the feature A feature that's ready for implementation label Jan 9, 2019
@prasannavl
Copy link
Contributor

Hi @leaxoy! Does #222 resolve this? :)

@leaxoy
Copy link
Contributor Author

leaxoy commented May 21, 2019

Looks cover this.

@leaxoy leaxoy closed this May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A feature that's ready for implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants