-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update http4s-circe, http4s-client, ... to 1.0.0-M40 in main #818
Conversation
#821 should be merged first |
* limitations under the License. | ||
*/ | ||
|
||
package org.http4s.internal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to bring this because of this refactoring https://github.com/http4s/http4s/pull/7175/files in core...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this repo should be writing to org.http4s.internal
. How about org.http4s.blaze.internal
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call! Will fix this
@rossabaker sorry for doxing, but I heard that now you may have the resources to glance at this PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you remember what imposed the LoggerFactory
on everything? I know a bunch of log4s changed to log4cats in the core repo, but I can't remember where the choice gets imposed on a backend.
* limitations under the License. | ||
*/ | ||
|
||
package org.http4s.internal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this repo should be writing to org.http4s.internal
. How about org.http4s.blaze.internal
?
@rossabaker perhaps these two PRs are responsible for the changes upon backend logging http4s/http4s#6645 http4s/http4s#7122 |
@rossabaker have all dragons been beaten? |
@rossabaker yet another friendly-ping on this 🙇🏻♂️ |
About this PR
📦 Updates
from
1.0.0-M39
to1.0.0-M40
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conf
file.Have a fantastic day writing Scala!
⚙ Adjust future updates
Add this to your
.scala-steward.conf
file to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency: