Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update http4s-circe, http4s-client, ... to 1.0.0-M40 in main #818

Merged
merged 13 commits into from
Aug 24, 2023

Conversation

http4s-steward[bot]
Copy link
Contributor

About this PR

📦 Updates

from 1.0.0-M39 to 1.0.0-M40

📜 GitHub Release Notes - Version Diff

Usage

Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

⚙ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.http4s" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.http4s" }
}]
labels: library-update, early-semver-pre-release, semver-spec-pre-release, version-scheme:early-semver, commit-count:1

@mergify mergify bot added the dependencies Dependency updates label Jul 13, 2023
@danicheg
Copy link
Member

#821 should be merged first

* limitations under the License.
*/

package org.http4s.internal
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to bring this because of this refactoring https://github.com/http4s/http4s/pull/7175/files in core...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this repo should be writing to org.http4s.internal. How about org.http4s.blaze.internal?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call! Will fix this

@danicheg danicheg requested a review from rossabaker July 18, 2023 09:20
@danicheg
Copy link
Member

danicheg commented Aug 1, 2023

@rossabaker sorry for doxing, but I heard that now you may have the resources to glance at this PR!

Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you remember what imposed the LoggerFactory on everything? I know a bunch of log4s changed to log4cats in the core repo, but I can't remember where the choice gets imposed on a backend.

* limitations under the License.
*/

package org.http4s.internal
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this repo should be writing to org.http4s.internal. How about org.http4s.blaze.internal?

@danicheg
Copy link
Member

danicheg commented Aug 2, 2023

@rossabaker perhaps these two PRs are responsible for the changes upon backend logging http4s/http4s#6645 http4s/http4s#7122

@danicheg
Copy link
Member

danicheg commented Aug 5, 2023

@rossabaker have all dragons been beaten?

@danicheg
Copy link
Member

@rossabaker yet another friendly-ping on this 🙇🏻‍♂️

@rossabaker rossabaker merged commit 1ca0d2d into main Aug 24, 2023
6 checks passed
@danicheg danicheg deleted the update/main/http4s-core-1.0.0-M40 branch August 25, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants