Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log errors in upgradeSocket #7363

Merged
merged 3 commits into from
Jan 23, 2024
Merged

Log errors in upgradeSocket #7363

merged 3 commits into from
Jan 23, 2024

Conversation

froth
Copy link
Member

@froth froth commented Jan 17, 2024

fixes #7356

Prevent error logs when client closes connection during socket upgrade.

@mergify mergify bot added series/0.23 PRs targeting 0.23.x module:ember-server labels Jan 17, 2024
@froth
Copy link
Member Author

froth commented Jan 18, 2024

@armanbilge I changed it to onError and mask. I was not sure whether only to handle the errors on tlsSocket.write or everything in upgradeSocket. I opted for the second.

That file feels a bit overwhelming to be honest, so maybe this is still way wrong 😅

froth and others added 2 commits January 18, 2024 08:34
@froth @armanbilge
Update ember-server/shared/src/main/scala/org/http4s/ember/server/int…
268b99b 
…ernal/ServerHelpers.scala

Co-authored-by: Arman Bilge <armanbilge@gmail.com>
@froth
Appease scalafmt
e063357
@froth froth requested a review from armanbilge January 23, 2024 18:10
armanbilge
armanbilge approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job tracking this one down! log-level is bike-sheddable but this is already an improvement so we can leave that to subsequent PRs.

@armanbilge armanbilge changed the title Handle socket error while upgradeSocket Log errors during upgradeSocket Jan 23, 2024
@armanbilge armanbilge changed the title Log errors during upgradeSocket Log errors in upgradeSocket Jan 23, 2024
@armanbilge armanbilge merged commit 4e5679d into http4s:series/0.23 Jan 23, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armanbilge armanbilge armanbilge approved these changes

Assignees
No one assigned
Labels
module:ember-server series/0.23 PRs targeting 0.23.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken Pipe error logs in Ember Server when using withTLS
2 participants
@froth @armanbilge