-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor imports to mirror those of Http4s #24
Labels
Comments
Sounds good, maybe I try it in a topic branch? |
Go forth and conquer, @before! |
@before, are you still interested in tackling this one? |
@bryce-anderson Obviously I have not enough time to start with it. Sorry for that. You should take this one if you have time. |
bryce-anderson
added a commit
that referenced
this issue
Aug 21, 2014
This seems too simple, I feel like I missed something. Issue #24
Commit 3c35b1c brings us in line with the core dsl, I believe. I just pushed that to master as it was so simple, almost too simple. |
Great, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The import style of Http4s has been changing, and I think rho should follow suit. Here is what I propose:
That would duplicate the Http4s imports, but we may deviate some. First, our route building is based on a trait, so we could include many of those imports in that trait automatically.
The text was updated successfully, but these errors were encountered: