Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor imports to mirror those of Http4s #24

Closed
bryce-anderson opened this issue Aug 14, 2014 · 6 comments
Closed

Refactor imports to mirror those of Http4s #24

bryce-anderson opened this issue Aug 14, 2014 · 6 comments

Comments

@bryce-anderson
Copy link
Member

The import style of Http4s has been changing, and I think rho should follow suit. Here is what I propose:

import org.http4s.rho._              // all important types should be in scope
import org.http4s.rho.Rho._          // all batteries included

That would duplicate the Http4s imports, but we may deviate some. First, our route building is based on a trait, so we could include many of those imports in that trait automatically.

@arouel
Copy link
Contributor

arouel commented Aug 14, 2014

Sounds good, maybe I try it in a topic branch?

@bryce-anderson
Copy link
Member Author

Go forth and conquer, @before!

@bryce-anderson
Copy link
Member Author

@before, are you still interested in tackling this one?

@arouel
Copy link
Contributor

arouel commented Aug 20, 2014

@bryce-anderson Obviously I have not enough time to start with it. Sorry for that. You should take this one if you have time.

bryce-anderson added a commit that referenced this issue Aug 21, 2014
This seems too simple, I feel like I missed something.
Issue #24
@bryce-anderson
Copy link
Member Author

Commit 3c35b1c brings us in line with the core dsl, I believe. I just pushed that to master as it was so simple, almost too simple.

@arouel
Copy link
Contributor

arouel commented Aug 22, 2014

Great, thank you

@arouel arouel closed this as completed Aug 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants