-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow failed validation to yield a Response instead of just a message #51
Comments
How about suggest |
This needs some cleanup and some consideration of the naming.
This is really great. I'm still reading it. I'm reading the tests/specs to understand, but since tests are often written in their own kind of test DSL, it would be even awesomer if you could add an example of each new feature into the (I'd envision these demo services turning into |
@refried, Good point on the examples. |
No, just that I think some ticket should remain open until examples can be added too. Otherwise go for it IMO. |
This is added but not yet well documented. I'm opening a new ticket for that. |
Oops yeah I was looking at the wrong commit. Thanks for adding this! |
It may be nice to yield a
401 Unauthorized
or some other type of status code. It should be easy to implement by changing theParserResult
types to either haveValidationFailure
contain aResponse
or add a new type with the same purpose.The text was updated successfully, but these errors were encountered: