We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IMO it worth add a bit more simple way of timeouts configuration:
HTTP.with_timeout(:per_request, :connect => 5, :read => 10, :write => 15)
The text was updated successfully, but these errors were encountered:
I would keep the ability to set a class, because it let's people write their own still. Although something that's maybe symbol or class would work.
And yea sorry, this slipped my mind. Realized it later when Tony brought it up.
Sorry, something went wrong.
I think I'd like to prefer the proliferation of #with_* prefixed things. I kind of regret introducing that convention in the first place.
#with_*
I'd suggest HTTP.timeout
HTTP.timeout
Both points make sense to me, so I guess it can be something like (pseudo code):
module HTTP def self.timeout(klass, opts = nil) timeout = Timeout[klass].new(opts) end class Timeout def self.[](klass_or_symbol) return klass_or_symbol if klass_or_symbol.is_a? Class case klass_or_symbol when :per_operation then PerOperation # ... end end end end
3121dad
Add simple way to configure timeouts.
4054cc2
Resolves httprb#205
No branches or pull requests
IMO it worth add a bit more simple way of timeouts configuration:
The text was updated successfully, but these errors were encountered: