Are you open to include rspec_matchers?

[stoivo]

I have used have_http_status from rspec-rails for a while an like it a lot. Would you be okay with including a custom rspec marcher?

I would like to implement something which looks like have_http_status. I was thinking of naming it have_httprb_status

[stoivo]

One alternative is to create a separate gem which has these marchers but I think it would be nice to have it here

[tarcieri]

A separate gem with the matchers seems good to me. @ixti what do you think?

[ixti]

Yeah, I believe separate gem is the best approach.

[ixti]

Just looked at Rails matcher impementation, we can actually provide 2 methods on response to make it compatible with have_http_status:

alias status_code code

def response_headers
  headers.to_h
end

[stoivo]

That would be an options but we don't know if the user are using or want to include rspec-rails. In this project I do but i see myself using rails less and less when hanami gets better

[stoivo]

If I create a repo with http_rb_rspec gem, with matchers. Would it be okey for it to live in httprb so you could do stuff with it if I'm not available. I can maintain it and release it but I would be nice it could live here to it's yours.

[ixti]

Sure. With pleasure!

…

On Wed, 26 Jul 2023, 16:38 Simon, ***@***.***> wrote: If I create a repo with http_rb_rspec gem, with matchers. Would it be okey for it to live in httprb so you could do stuff with it if I'm not available. I can maintain it and release it but I would be nice it could live here to it's yours. — Reply to this email directly, view it on GitHub <#755 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAXEPXGAUDJECOELLWSOADXSETXRANCNFSM6AAAAAA2BXZSHU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[ixti]

I'll create a repo and grant you access today.

[stoivo]

I have the matcher and the gem ready ready. I can't find the invite did you create it?

[stoivo]

I created a repo just to show what I did https://github.com/stoivo/httprb_rspec

[ixti]

Sorry. Was off the grid a bit. Created http-rspec repo and invited you to it.

A couple of thoughts on that one:

1. I think a better name would be http-rspec (so that it's http gem's name + rspec)
2. Default require should be: require "http/rspec"
3. I believe we can use have_http_status as matcher name, or, to avoid any name conflicts (and deal with conditional proxying) we can have matcher: be_an_http_gem_response.with(status: ...)

[stoivo]

1. Oh, thought I check I thought it was taken. I agree that we should use this name instead.
2. Ok. will fix
3. rspec-rails adds have_http_status to all scoped so we will have to deal with conflict we we use that name. https://github.com/rspec/rspec-rails/blob/71a5751760f64ec86c2c51545c9894abee867d6f/lib/rspec/rails/configuration.rb#L55-L55. I do think be_an_http_gem_response.with(status: ... ) is a bit long, but I will get used to it and I could alias it if I want it to be shorten in one spec. This api also allows easy expansion to check headers and body potentially also be_an_http_gem_request and check headers and body.

[stoivo]

it is released. I don't know how I can make it so you can release it too

[stoivo]

I added ixti and tarcieri so some of you have release access. Somebody else I should add?

[tarcieri]

That's fine

[ixti]

@stoivo can you send me an invite once again? I was off-the grid.

[stoivo]

Was getting some weird errors so I removed you and added you again.

$ gem owner http-rspec --add ixti
You have enabled multi-factor authentication. Please enter OTP code.
Code:   ****
Adding ixti: User has already been taken

$ gem owner http-rspec --remove ixti
You have enabled multi-factor authentication. Please enter OTP code.
Code:   ****
The existing key doesn't have access of remove_owner on RubyGems.org. Please sign in to update access.
   Email:   simon.toivo@telhaug.no
Password:
Added remove_owner scope to the existing API key
Owner removed successfully.
Owners for gem: http-rspec
- tarcieri
- stoivo

$ gem owner http-rspec --add ixti
You have enabled multi-factor authentication. Please enter OTP code.
Code:   ***
ixti was added as an unconfirmed owner. Ownership access will be enabled after the user clicks on the confirmation mail sent to their email.
Owners for gem: http-rspec
- tarcieri
- stoivo

@ixti, did it work? if not I will send an imail to rubygems

[ixti]

@ixti, did it work? if not I will send an imail to rubygems

Yup, thank you!