Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close connection in case of error. #269

Closed
ixti opened this issue Dec 12, 2015 · 3 comments
Closed

Close connection in case of error. #269

ixti opened this issue Dec 12, 2015 · 3 comments

Comments

@ixti
Copy link
Member

ixti commented Dec 12, 2015

Right now we close connection in client upon case of error only if client is persistent.
https://github.com/httprb/http/blob/master/lib/http/client.rb#L78

IMO that line should be just close without the guard.

@zanker @tarcieri thoughts?

@zanker
Copy link
Contributor

zanker commented Dec 12, 2015

I have no idea why I made it only close persistent ones. 👍 on fixing.

Sent from my iPhone

On Dec 12, 2015, at 06:02, Alexey Zapparov notifications@github.com wrote:

Right now we close connection in client upon case of error only if client is persistent.
https://github.com/httprb/http/blob/master/lib/http/client.rb#L78

IMO that line should be just close without the guard.

@zanker @tarcieri thoughts?


Reply to this email directly or view it on GitHub.

@sferik
Copy link
Contributor

sferik commented Dec 12, 2015

👍

@tarcieri
Copy link
Member

also 👍

@ixti ixti closed this as completed in 2663da6 Dec 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants