We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Right now we close connection in client upon case of error only if client is persistent. https://github.com/httprb/http/blob/master/lib/http/client.rb#L78
IMO that line should be just close without the guard.
close
@zanker @tarcieri thoughts?
The text was updated successfully, but these errors were encountered:
I have no idea why I made it only close persistent ones. 👍 on fixing.
Sent from my iPhone
On Dec 12, 2015, at 06:02, Alexey Zapparov notifications@github.com wrote: Right now we close connection in client upon case of error only if client is persistent. https://github.com/httprb/http/blob/master/lib/http/client.rb#L78 IMO that line should be just close without the guard. @zanker @tarcieri thoughts? — Reply to this email directly or view it on GitHub.
On Dec 12, 2015, at 06:02, Alexey Zapparov notifications@github.com wrote:
— Reply to this email directly or view it on GitHub.
Sorry, something went wrong.
👍
also 👍
2663da6
No branches or pull requests
Right now we close connection in client upon case of error only if client is persistent.
https://github.com/httprb/http/blob/master/lib/http/client.rb#L78
IMO that line should be just
close
without the guard.@zanker @tarcieri thoughts?
The text was updated successfully, but these errors were encountered: