Allow http_parser to decide if there is still body to read #424
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It mostly fixes problem when connection which uses "Transfer-Encoding: chunked" header is closed to early, before the terminating chunk is received. In such case "http" returned partial body instead of raising error.
Here is how the problem can be reproduced:
Run this app (
rackup -p 3000 -E none -s puma
):Use irb console to make http request to the app and then kill the app (in the middle of the request):
All tests are passing so my fix seems to be fine, but if you think otherwise let me know and I'll try change it.