Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump llhttp-ffi (0.5.0) #744

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Conversation

bryanp
Copy link
Contributor

@bryanp bryanp commented Mar 29, 2023

Updates the llhttp-ffi dependency to v0.5.0. The only difference is that it now uses lhttp v8.1.0, the latest release.

@bryanp
Copy link
Contributor Author

bryanp commented Mar 29, 2023

Note I am seeing one test failure on this branch but also see it in main:

1) HTTP::Options headers accepts any object that respond to :to_hash
     Failure/Error: x = Struct.new(:to_hash).new("accept" => "json")

     ArgumentError:
       unknown keywords: accept
     # ./spec/lib/http/options/headers_spec.rb:17:in `initialize'
     # ./spec/lib/http/options/headers_spec.rb:17:in `new'
     # ./spec/lib/http/options/headers_spec.rb:17:in `block (2 levels) in <top (required)>'

@tarcieri tarcieri merged commit ed8bd1f into httprb:main Mar 30, 2023
@bryanp bryanp deleted the chg/update-llhttp-ffi-0.5.0 branch March 30, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants