Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Brotli v5 #34

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Upgrade to Brotli v5 #34

merged 1 commit into from
Apr 18, 2024

Conversation

nyurik
Copy link
Contributor

@nyurik nyurik commented Apr 17, 2024

No description provided.

@CLAassistant
Copy link

CLAassistant commented Apr 17, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

pimterry
pimterry approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@pimterry pimterry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Looks great. Looks like there's some unrelated build issues here due to type changes elsewhere - I'll sort that out now, then rebase this and merge assuming that gets the build passing. 👍

@pimterry pimterry merged commit 8de3071 into httptoolkit:main Apr 18, 2024
7 checks passed
@nyurik nyurik deleted the brotli-upd branch April 19, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pimterry pimterry pimterry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nyurik @CLAassistant @pimterry