Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .js file extension to import, to make importmap work out of the box #36

Merged
merged 4 commits into from
Jun 3, 2024
Merged

Add .js file extension to import, to make importmap work out of the box #36

merged 4 commits into from
Jun 3, 2024

Conversation

heidemn
Copy link
Contributor

@heidemn heidemn commented May 31, 2024

Fixes #35.

@CLAassistant
Copy link

CLAassistant commented May 31, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@pimterry pimterry merged commit 63ffc72 into httptoolkit:main Jun 3, 2024
7 checks passed
@pimterry
Copy link
Member

pimterry commented Jun 3, 2024

Makes sense, thanks for fixing that! Now released as v3.0.1.

@heidemn
Copy link
Contributor Author

heidemn commented Jun 3, 2024

@pimterry thanks, that was quick!
I can confirm that with v3.0.1 the importmap now works out of the box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pimterry pimterry pimterry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Browser importmap should not require additional override (using index.web.js)
3 participants
@heidemn @CLAassistant @pimterry