clarify case-sensitivity of upgrade tokens (closes #8) #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
royfielding
requested changes
Sep 19, 2018
There was a problem hiding this comment.
I don’t think this is quite what we need. I’ve added more comments to the issue #8
|
I think you convinced me that it is better to define the token as case-insensitive (for Upgrade) while encouraging that senders to send the registered case. Hence, a different change. |
royfielding
approved these changes
Mar 8, 2019
royfielding
approved these changes
Mar 8, 2019
|
Hmm, github really doesn't want me to ask @reschke to review his own PR, even though I changed it. I must have broken someone's idea of collaboration. |
|
LGTM |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.