Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookie tests should not be using the CookieStore API #2089

Closed
mozfreddyb opened this issue May 4, 2022 · 3 comments
Closed

Cookie tests should not be using the CookieStore API #2089

mozfreddyb opened this issue May 4, 2022 · 3 comments
Labels

Comments

@mozfreddyb
Copy link

Hi folks working on 6265bis,

We've been ramping up various work on getting Firefox closer towards the latest 6265bis draft.
When reviewing the pull request #1732, I noticed that the wpt tests developed alongside are using the CookieStore API that is only supported by Chromium browsers.

Considering previous and ongoing work to improve Cookie APIs in the test infra (web-platform-tests/rfcs#74, web-platform-tests/rfcs#108), may I suggest that we refrain from using the CookieStore API in for new changes and their tests?

@miketaylr
Copy link
Collaborator

heya @mozfreddyb - can you link to the tests in question? I agree we shouldn't use that API to test cookies, but it would be helpful if you can point to the tests (or file a bug on WPT or Chromium and tag me).

@mozfreddyb
Copy link
Author

Scrolling down from the pull request #1732, you'll see a commit to the CookieStore API tests.

I was under the impression that those were meant to be the accompanying commits to wpt for that cookie spec change. Revisiting the commits, I now understand that this is not the case. That commit merely changes the default expiry behavior for the existing CookieStore API tests. In fact, there are no accompanying commits to wpt for #1732 at all. My apologies.

@miketaylr
Copy link
Collaborator

All good, seems like we can close here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants