RFC 74: Add testdriver.js support for WebDriver delete_all_cookies command #74
Conversation
|
WebDriver doesn't seem particularly detailed about how it serializes cookie values. That seems rather important to address first, at least before adding anything apart from "delete all", given that JSON doesn't have a native representation for byte sequences. (This concern might also apply to cookie names, not sure.) |
This is the one bit I'm actually interested in right now, so I'm happy to reduce the scope of the RFC to land this without blocking on the rest. |
|
Sounds good, I filed w3c/webdriver#1562 on WebDriver for the serialization issue. |
|
I think this makes sense. |
miketaylr
changed the title
Thanks. I've updated the RFC as well. |
|
|
||
| ## Risks | ||
|
|
||
| This increases the API surface of testdriver.js, so it's more code to maintain or reason about. In addition, the developer experience of running local cookie tests will be less convenient (requiring `wpt run` instead of just hitting refresh). |
There was a problem hiding this comment.
As just a side-note; if you running a single test under wpt run we do keep the test window open after the test finishes and I believe refreshing the test should work fine. (Unless there's weird stateful things happening I don't know about).
|
It's been 7 days with no objections, shall we merge this? |
PR to add support for
delete_all_cookieshere: web-platform-tests/wpt#26723