Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New APIG environment resource support #1267

Merged
merged 3 commits into from
Jul 15, 2021
Merged

New APIG environment resource support #1267

merged 3 commits into from
Jul 15, 2021

Conversation

Lance52259
Copy link
Collaborator

@Lance52259 Lance52259 commented Jul 7, 2021

What this PR does / why we need it:
In order to support APIG group binding variables and API usage, HuaweiCloud needs an environment resource.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
reference: #1249

Special notes for your reviewer:

Release note:

1. New environment resource supports variables binding.
2. New related acc test.
  - unit test for name and description for updates.
3. New related document.

PR Checklist

  • Tests added/passed.
  • Documentation updated.
  • Schema updated.

Acceptance Steps Performed

make testacc TEST='./huaweicloud/services/acceptance/apig' TESTARGS='-run=TestAccApigEnvironmentV2_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/apig -v -run=TestAccApigEnvironmentV2_basic -timeout 360m -parallel 4
=== RUN   TestAccApigEnvironmentV2_basic
=== PAUSE TestAccApigEnvironmentV2_basic
=== CONT  TestAccApigEnvironmentV2_basic

--- PASS: TestAccApigEnvironmentV2_basic (448.95s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/apig      449.007s

Computed: true,
ForceNew: true,
},
"instance_id": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing ForceNew

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added missing ForceNew

@ShiChangkuo ShiChangkuo merged commit 882e0b6 into huaweicloud:master Jul 15, 2021
@Lance52259 Lance52259 deleted the br_apig_environment_active branch August 31, 2021 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants