add compute_instace extend system disk support #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niuzhenguo
requested changes
Sep 15, 2020
|
|
||
| err = volumeactions.ExtendSize(blockStorageClient, systemDiskID, extendOpts).ExtractErr() | ||
| if err != nil { | ||
| return fmt.Errorf("Error extending huaweicloud_blockstorage_volume_v2 %s size: %s", systemDiskID, err) |
There was a problem hiding this comment.
Error extending huaweicloud_compute_instance system disk size
| Pending: []string{"extending"}, | ||
| Target: []string{"available", "in-use"}, | ||
| Refresh: VolumeV2StateRefreshFunc(blockStorageClient, systemDiskID), | ||
| Timeout: d.Timeout(schema.TimeoutCreate), |
| _, err = stateConf.WaitForState() | ||
| if err != nil { | ||
| return fmt.Errorf( | ||
| "Error waiting for huaweicloud_blockstorage_volume_v2 %s to become ready: %s", systemDiskID, err) |
There was a problem hiding this comment.
Error waiting for volume %s ...
| @@ -229,7 +229,8 @@ The following arguments are supported: | |||
| * `co-p1`: high I/O(performance-optimized) disk type. | |||
| * `uh-l1`: ultra-high I/O(latency-optimized) disk type. | |||
|
|
|||
| * `system_disk_size` - (Optional) The system disk size in GB, The value range is 1 to 1024. Changing this creates a new server. | |||
| * `system_disk_size` - (Optional) The system disk size in GB, The value range is 1 to 1024. Changing this parameter will update the disk. | |||
| You can extend the disk by setting this parameter to a new value, which must be between current size and the max size. Shrinking the disk is not supported. | |||
There was a problem hiding this comment.
need to be more specified for the max size, or just not mention it.
Jason-Zhang9309
force-pushed
the
dev-compute-instance-sysdisk-extend
branch
from
e305cc0
to
2dd2567
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.