Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify the nat gateway client to customize nat service endpoint by nat key #899

Merged
merged 2 commits into from
Feb 4, 2021

Conversation

ShiChangkuo
Copy link
Collaborator

@ShiChangkuo ShiChangkuo commented Feb 4, 2021

What this PR does / why we need it:
unify the nat gateway client to NatGatewayClient, so we can customize nat service endpoint by nat key.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer:

Release note:


PR Checklist

  • Tests added/passed.
  • Documentation updated.
  • Schema updated.

Acceptance Steps Performed

$ make testacc TEST='./huaweicloud' TESTARGS='-run TestAccNatSnatRule_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud -v -run TestAccNatSnatRule_basic -timeout 360m -parallel 4
=== RUN   TestAccNatSnatRule_basic
=== PAUSE TestAccNatSnatRule_basic
=== CONT  TestAccNatSnatRule_basic
--- PASS: TestAccNatSnatRule_basic (108.33s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud       108.380s

@ShiChangkuo ShiChangkuo changed the title Clean code unify the nat gateway client to NatGatewayClient to customize nat service endpoint by nat key Feb 4, 2021
@ShiChangkuo ShiChangkuo changed the title unify the nat gateway client to NatGatewayClient to customize nat service endpoint by nat key unify the nat gateway client to customize nat service endpoint by nat key Feb 4, 2021
@ShiChangkuo ShiChangkuo merged commit 464863d into huaweicloud:master Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant