Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the type of volume extend_param to map #904

Merged
merged 1 commit into from
Feb 7, 2021

Conversation

Jason-Zhang9309
Copy link
Collaborator

What this PR does / why we need it:

change the type of volume extend_param to map
In the API docs the type of root_volume and data_volumes in cce node is Map, but it was String in our code, this problem need to be fixed.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


PR Checklist

  • Tests added/passed.
  • Documentation updated.
  • Schema updated.

Acceptance Steps Performed

make testacc TEST='./huaweicloud' TESTARGS='-run TestAccCCENodeV3_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud -v -run TestAccCCENodeV3_basic -timeout 360m -parallel 4
=== RUN   TestAccCCENodeV3_basic
=== PAUSE TestAccCCENodeV3_basic
=== CONT  TestAccCCENodeV3_basic
--- PASS: TestAccCCENodeV3_basic (1698.66s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud       1698.739s

@ShiChangkuo ShiChangkuo merged commit d7e0a9b into huaweicloud:master Feb 7, 2021
@Jason-Zhang9309 Jason-Zhang9309 deleted the dev-cce-node branch February 8, 2021 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants